Skip to content

fix(integration): fix flaky keyless popover tests #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jacekradko wants to merge 1 commit into from
Closed

fix(integration): fix flaky keyless popover tests #7807

jacekradko wants to merge 1 commit into from

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Feb 9, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Replace external dashboard navigation with href attribute assertions in keyless popover integration tests
  • The "Toggle collapse popover and claim" and "Lands on claimed application" tests were flaky because they navigated to the external Clerk Dashboard and waited for redirects, which is subject to network latency and dashboard availability in CI
  • Instead of opening a new tab and waiting for the dashboard redirect chain, the tests now verify the link's href attribute contains the correct dashboard URL and expected parameters

Test plan

  • Verify quickstart (chrome, 15) integration tests pass
  • Verify quickstart (chrome, 16) integration tests pass
  • Verify tanstack-react-start (chrome) integration tests pass

Summary by CodeRabbit

  • Tests
    • Improved test reliability by replacing navigation-based assertions with direct href verification in keyless authentication flows, reducing flaky CI behavior and eliminating cross-origin navigation dependencies.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: 908ddcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 9, 2026 9:58pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

Two integration test files have been refactored to replace navigation-based verification with static href attribute checks. Instead of opening new pages and waiting for URL validation, the tests now directly inspect the href attributes of claim and claimed-keys links to verify they contain expected dashboard URLs and tokens. The changes remove cross-origin navigation patterns from the test execution flow. Inline comments were added to document the rationale for this approach.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly addresses the main change: fixing flaky keyless popover tests by replacing navigation-based assertions with href checks, eliminating cross-origin navigation and CI flakiness.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 9, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7807

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7807

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7807

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7807

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7807

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7807

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7807

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7807

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7807

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7807

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7807

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7807

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7807

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7807

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7807

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7807

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7807

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7807

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7807

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7807

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7807

commit: 908ddcd

@jacekradko jacekradko closed this Feb 9, 2026
@jacekradko jacekradko deleted the jrad/fix-flaky-keyless-tests branch February 9, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core-3 integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jacekradko